chore: unskip tests #25676
Merged
chore: unskip tests #25676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 flaky tests on run #43720 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | ||
|---|---|---|
| ... > with `times` > only uses each handler N times | ||
| ... > stops waiting when an xhr request is canceled | ||
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit
| Test | ||
|---|---|---|
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
lmiller1990
commented
Feb 2, 2023
| @@ -259,8 +259,6 @@ describe('Launchpad: Setup Project', () => { | |||
| cy.findByRole('button', { name: 'Continue' }) | |||
| .should('not.have.disabled') | |||
| .click() | |||
|
|
|||
| verifyChooseABrowserPage() | |||
There was a problem hiding this comment.
covered in many other places - covering it here would require us to add dependencies to the pristine project, which would slow down the run for no additional coverage
flotwig
reviewed
Feb 2, 2023
Co-authored-by: Zach Bloomquist <git@chary.us>
flotwig
approved these changes
Feb 2, 2023
mike-plummer
approved these changes
Feb 2, 2023
tgriesser
added a commit
that referenced
this pull request
Feb 8, 2023
* develop: (28 commits) chore: update changelog validation example (#25742) fix: Improve error handling around calls to `this.next` in middleware (#25702) chore: debug page tooltip distance and artifact border (#25727) fix: update newProject ref when switching between organizations in SelectCloudProjectModal (#25730) misc: Add max widths to debug page message states (#25725) chore: export types (#25714) chore: release @cypress/webpack-preprocessor-v5.16.3 chore: release @cypress/vue-v5.0.4 chore: release @cypress/grep-v3.1.4 chore: Fix flaky test (#25726) dependency(deps): update dependency debug to ^4.3.4 🌟 (#25699) feat: openInIDE for failed debug spec (#25691) test: fix flaky CT test by relying on query (#25706) test: fix flaky migration test (#25672) misc: style change for responsiveness (#25687) misc: set min widths for icons (#25684) chore(deps): update dependency markdown-it to v11.0.1 🌟 (#25698) chore: Fix flaky origin .wait() test (#25693) chore: unskip tests (#25676) chore: release @cypress/webpack-preprocessor-v5.16.2 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unskipped some tests that were skipped.