Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark notebooks for medium and late stages #55

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Jun 5, 2020

Requirement(s):

Description:

This PR adds ,

  • the notebooks which were missing (they needed large scale analyses to be used)
    • energy estimation,
    • particle classification,
    • angular distribution (in particular the PSF),
    • IRFs and sensitivity curve
  • reference data for some plots
    • CTA requirements
    • ASWG data (old, to be updated and explicited)

Caveats:

Due to the fact that the GRID usage has been put on hold for so long,

  • these notebooks are far from being complete products,
  • it is possible that bugs are present
  • they constitute somewhat a spin-off of ctaplot + cta-benchmarks (it is possible that some things could be recycled!)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@HealthyPear HealthyPear added benchmarks documentation Documentation or services hosting it maintenance labels Jun 5, 2020
@HealthyPear HealthyPear added this to the Release 0.3 milestone Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #55   +/-   ##
======================================
  Coverage    0.39%   0.39%           
======================================
  Files          20      20           
  Lines        2268    2268           
======================================
  Hits            9       9           
  Misses       2259    2259           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8088f...7547b1a. Read the comment docs.

Copy link
Contributor

@kosack kosack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think most of these will be merged with ctaplot/cta-benchmarks later (as already mentioned in the PR), but for now this is fine

@HealthyPear HealthyPear merged commit 0704409 into cta-observatory:master Jun 15, 2020
@HealthyPear HealthyPear deleted the benchmarking-add_missing_notebooks branch June 15, 2020 14:18
@vuillaut
Copy link
Member

All the reference datasets (and more) added in this PR are available in ctaplot:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks documentation Documentation or services hosting it maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants