Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added
protopipe.pipeline.utils.prod3b_array
I made some changes that influenced the grid interface code.Since at the time the GRID support was put on hold, I didn't even think that it could be a problem.
Indeed since the 2 repos are de facto separated, there was no automatic test to catch this...
The following changes have been rolled back now:
I added back that argument the must be filled by the user.
One can put also all the cameras, since
protopipe.pipeline.utils.prod3b_array
will take care of it anyway (making that argument a dummy one).write_dl1.py
,Other changes:
I also added a comment about using absolute paths when defining the simtel files lists to be used.
This is useful since I plan to enable the use of a container and the paths could be different from my personal setup.
Note: we should check if something like
protopipe.pipeline.utils.prod3b_array
already exists in ctapipe for Prod3b, otherwise it would be wise to add it, at least for Prod5 (issue to be opened soon to be sure).