-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Newtonsoft.Json package with System.Text.Json #1513
Replace Newtonsoft.Json package with System.Text.Json #1513
Conversation
6c06d39
to
f8dcd31
Compare
@daveMueller @MarcoRossignoli ![]() |
That's really cool, @daveMueller do you plan to review this one? |
Yes I will. As I understood it's the same changes as in #1510 but instead of updating |
I will rebase this branch after #1510 is merged 😉 |
c9e23de
to
16cdd64
Compare
@Bertk I see you a lot active on coverlet, let me know if you're interested to become a co-maintainer and help to keep the product in a good shape. You can contact me on twitter https://twitter.com/MarcoRossignoli or let me know how we can have a chat Not mandatory at all it's OSS so no obligation. |
@MarcoRossignoli Can we have a chat on Monday Zoom or MS Teams will be fine. |
16cdd64
to
aabfdc3
Compare
@daveMueller @MarcoRossignoli Please review and approve PR. Please note: I wanted to check stderr with the last commit but after the update the CI tests were successful. By the way, the obsolete PR #1358 should be closed. |
51c6d81
to
49afd1b
Compare
49afd1b
to
0f1c051
Compare
@daveMueller Please review PR. This has also the code coverage report for the AzureDevOps build pipeline. |
6893fb0
to
c3710a9
Compare
c3710a9
to
b4ad03d
Compare
@daveMueller I added code coverage badge and trx files which have the output attachments. The PR is ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Bertk 👍
❗ PR #1510 should be merged before this one. The System.Text.Json updates shall be merges separately.