-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Newtonsoft.Json version and other nuget versions (use CPM) #1510
Update Newtonsoft.Json version and other nuget versions (use CPM) #1510
Conversation
bde7c2d
to
e595642
Compare
e595642
to
63f6b28
Compare
@MarcoRossignoli @daveMueller Please review PR. |
63f6b28
to
f6d0adf
Compare
ae05b55
to
3ff04de
Compare
944ccaa
to
f80ac39
Compare
f80ac39
to
7df9aa0
Compare
inputs: | ||
version: 5.0.401 | ||
displayName: Install .NET Core SDK 5.0.401 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bertk Thanks a lot for your time-consuming contributions 🙏 . I've seen your comment in #1511 (comment) regarding this topic but PR was already merged at that time. I think you are right that we don't need them anymore. Especially if we migrate all the test projects to net6.0
like you have done in this PR.
Personally I'm not sure if we shouldn't keep 1-2 legacy netcoreapp3.1
projects to have a wider range of test scenarios regarding instrumentation... What do you think @MarcoRossignoli?
Thanks again, I really like the changes in this PR and will try to do a proper review in the next days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to test and ship only supported versions announced here https://learn.microsoft.com/en-us/lifecycle/products/microsoft-net-and-net-core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shows supported versions much better 😉
https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core
@daveMueller is this good to go? |
Sorry didn't find time yet to look into it. Most likely on the weekend. |
alternative: #1513