compat: /auth: parse server address correctly

[vrothberg]

Use auth.Login as podman login does which parses and normalizes the
input addresses correctly, especially for docker.io.

[NO NEW TESTS NEEDED] as we do not have means to test logging into
docker.io in CI.

Fixes: #17571
Signed-off-by: Valentin Rothberg vrothberg@redhat.com

Does this PR introduce a user-facing change?

Fix a bug in the Docker-compatible REST APIs `/auth` endpoint to correctly log into Docker Hub.

[edsantiago]

WHOA. Test failures:

# podman --events-backend=file events --stream=false --filter type=image --since 2023-02-20T11:00:02-06:00
[fail expected this got that]

and

#|     FAIL: Image found in events
#| expected: =~ \"Name\":\"quay.io/libpod/testimage:20221018\"
#|   actual:    \{\"ID\":\"f5a99120db6452661930a1db3bf7390eec9b963f5f62c068fa32dc1d550afad3\"\,
\"Name\":\"f5a99120db6452661930a1db3bf7390eec9b963f5f62c068fa32dc1d550afad3\"\,
\"Status\":\"pull\"\,
\"Time\":\"2023-02-20T11:00:13.133325023-06:00\"\,
\"Type\":\"image\"\,\"Attributes\":null\}

...look exactly the same as unexplained but persistent failure in nightly treadmill job

@containers/podman-maintainers PTAL, this looks serious.

[vrothberg]

I probably broke that. Will take a look tomorrow!

…

On Mon 20 Feb 2023 at 20:56, Ed Santiago ***@***.***> wrote: WHOA. Test failures <https://api.cirrus-ci.com/v1/artifact/task/6337919997181952/html/sys-podman-fedora-36-root-host.log.html#t--00208> : # podman --events-backend=file events --stream=false --filter type=image --since 2023-02-20T11:00:02-06:00 [fail expected this got that] and #| FAIL: Image found in events #| expected: =~ \"Name\":\"quay.io/libpod/testimage:20221018\ <http://quay.io/libpod/testimage:20221018%5C>" #| actual: \{\"ID\":\"f5a99120db6452661930a1db3bf7390eec9b963f5f62c068fa32dc1d550afad3\"\, \"Name\":\"f5a99120db6452661930a1db3bf7390eec9b963f5f62c068fa32dc1d550afad3\"\, \"Status\":\"pull\"\, \"Time\":\"2023-02-20T11:00:13.133325023-06:00\"\, \"Type\":\"image\"\,\"Attributes\":null\} ...look exactly the same as unexplained but persistent failure in nightly treadmill job <https://api.cirrus-ci.com/v1/artifact/task/6181517337034752/html/sys-podman-fedora-37-root-host.log.html#t--00208> @containers/podman-maintainers </~https://github.com/orgs/containers/teams/podman-maintainers> PTAL, this looks serious. — Reply to this email directly, view it on GitHub <#17581 (comment)>, or unsubscribe </~https://github.com/notifications/unsubscribe-auth/ACZDRA7KRRVRHV7MIYGAY33WYPD53ANCNFSM6AAAAAAVB7Z67E> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[vrothberg]

containers/common#1339 will fix it. Once that got in, I'll update the PR here along with minor tweaks to the system test.

[vrothberg]

Breaking out the c/common vendor into #17591.

This should buy me some time looking into what breaks because of the /auth changes.

[vrothberg]

@Luap99 @edsantiago PTAL

I'm not happy about the error check but it's a smaller problem than the bug. Will look into separately as changing the error would impact skopeo and buildah as well.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

Updated. Vendored in c/common to keep the error handling.

[rhatdan]

LGTM

[mheon]

Changes LGTM

[Luap99]

You need to update the tests, the runtime-spec update changed the version the tests expect:

podman/libpod/container_internal_test.go

Line 181 in 1cfb29d

stateRegexp := `{"ociVersion":"1\.0\.2-dev","id":"123abc","status":"stopped","bundle":"` + dir + `","annotations":{"a":"b"}}`

[vrothberg]

You need to update the tests, the runtime-spec update changed the version the tests expect:

podman/libpod/container_internal_test.go

Line 181 in 1cfb29d

stateRegexp := `{"ociVersion":"1\.0\.2-dev","id":"123abc","status":"stopped","bundle":"` + dir + `","annotations":{"a":"b"}}`

Thanks! Will do. Had to focus on #17615 until now.

[vrothberg]

Rebased, should pass now

[vrothberg]

@rhatdan @Luap99 merge me please

[vrothberg]

or @edsantiago :)

[edsantiago]

/lgtm
/hold

[vrothberg]

/hold cancel

[TomSweeneyRedHat]

Also fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2183596 and https://bugzilla.redhat.com/show_bug.cgi?id=2183597