-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with DOCKER_HOST
and add limited Podman CI workflow
#494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cristianrgreco
added
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Mar 15, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed Docker/Podman differences:
https://index.docker.io/v1/
), but Podman stores just the host (index.docker.io
), so we do not work with private registries in Docker hub.HostIp
containers/podman#17780)Debian_Testing
https://index.docker.io/v1/
(GET /info
not returningIndexServerAddress
containers/podman#17776)pull
must be boolean, whereas string is supported by Docker (Build imagepull
field type mismatch with Docker containers/podman#17778)pull
set to true containers/podman#17779)Observed Docker/Colima differences:
This PR will keep a basic podman workflow which runs the generic-container tests. It has already provided value in discovering an existing issue with the
DOCKER_HOST
environment variable, which this PR also fixes (fixes #487).