Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

another mount race: ctr XYZ is a libpod container: container already exists #23637

Closed
edsantiago opened this issue Aug 15, 2024 · 0 comments · Fixed by #23645
Closed

another mount race: ctr XYZ is a libpod container: container already exists #23637

edsantiago opened this issue Aug 15, 2024 · 0 comments · Fixed by #23645
Assignees
@Luap99
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Looks similar to #23507 (whose fix is already in the code I'm running):

         not ok 61 |060| podman mount external container - basic test in 449ms
...
<+026ms> # # podman mount --notruncate
<+056ms> # Error: ctr a5361035a5628efdd0b4947812ddb077854f202ec5877b7fc27c0b9cd12ebe7c is a libpod container: container already exists
<+004ms> # [ rc=125 (** EXPECTED 0 **) ]

This is in parallel system tests where presumably objects are being created/removed unpredictably.

Not much to go on, but journal shows the container safename being t-55 which corresponds to podman stop, with --rm container, which simply does podman run -d --rm sleep then podman stop -t0. That's where I'd begin with a reproducer, that in one loop, podman mount in another.
@edsantiago edsantiago added the flakes Flakes from Continuous Integration label Aug 15, 2024
@Luap99 Luap99 self-assigned this Aug 16, 2024
Luap99 added a commit to Luap99/libpod that referenced this issue Aug 16, 2024
@Luap99
podman mount: fix storage/libpod ctr race
7a7aec3 
When we create a container we first create it in the storage then in the
libpod db so there is a tiny window where it is seen as storage ctr but
then by the time we mount it we see it was a libpod container.

Fixes containers#23637

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 mentioned this issue Aug 16, 2024
Merged
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 15, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

podman mount: fix storage/libpod ctr race Luap99/libpod
2 participants
@edsantiago @Luap99