-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman mount: fix storage/libpod ctr race #23645
Conversation
When we create a container we first create it in the storage then in the libpod db so there is a tiny window where it is seen as storage ctr but then by the time we mount it we see it was a libpod container. Fixes containers#23637 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
@edsantiago PTAL, I think this is the only place where this error could happen |
LGTM |
/lgtm |
e8410b8
into
containers:main
When we create a container we first create it in the storage then in the libpod db so there is a tiny window where it is seen as storage ctr but then by the time we mount it we see it was a libpod container.
Fixes #23637
Does this PR introduce a user-facing change?