Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modern: bump base to Bionic #466

Merged
merged 6 commits into from
Oct 11, 2022
Merged

Conversation

ericLemanissier
Copy link
Contributor

Until now, all modern images are based on Xenial, which is "End of standard support" since April 2021. It is a problem for projects like Qt which do not support Xenial any more. In the case of Qt, the compilation fails because xenial's system package for xcb-randr0 is too old (cf conan-io/conan-center-index#12620 (comment)). I don't think there is any acceptable workaround, cf conan-io/conan-center-index#12620 (comment))

CC @jgsogo @uilianries @danimtb @jcar87

Changelog: Fix : modern docker image are based on Ubuntu Bionic

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've followed the Best Practices guides for Dockerfile.

@uilianries
Copy link
Member

uilianries commented Sep 28, 2022

My hand is shaking to merge it at once!

@uilianries
Copy link
Member

It failed due a server error (not our side). Just restarted it now.

@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Sep 28, 2022

My hand shaking to merge it at once!

😄 Do we have a consensus that migrating to bionic is ok ?

@uilianries
Copy link
Member

@ericLemanissier we still need some data, number of packages downloaded related to that distro.

Personally, I'm inclined to update it too.

@uilianries uilianries closed this Sep 28, 2022
@uilianries uilianries reopened this Sep 28, 2022
@uilianries
Copy link
Member

Archive:  ninja-linux.zip

  inflating: ninja                   

E: gnupg, gnupg2 and gnupg1 do not seem to be installed, but one of them is required for this operation

the clang-builder requires one of these packages

@uilianries
Copy link
Member

We will discuss next week about this PR, hope we can update it soon.

@ericLemanissier
Copy link
Contributor Author

for the record, all qt pull requests have been blocked by this issue for a month. As a consequence the last two versions of qt are not available on CCI. Some decision has to be taken one way or the other

@ericLemanissier
Copy link
Contributor Author

@uilianries do we have a plan? Or should affected recipes raise ConanInvalidConfiguration based on lsb_release ?

@uilianries
Copy link
Member

@ericLemanissier I built all images and I gonna test it today. Next week, if all occurs fine, we can start to migrate.

@uilianries
Copy link
Member

I did some tests today and looks good.

I installed Boost, Poco, Cmake, opencv, ffmpeg and other pre-built packages from Conan Center, to a GCC 11 Ubuntu 18.04 from this PR and executed the test package, using option shared with libstdc++/11 combination. So far, no runtime errors.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries uilianries merged commit aa52cf5 into conan-io:master Oct 11, 2022
@uilianries
Copy link
Member

@ericLemanissier Thank you for updating it! This PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants