-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RuntimeQml Package #13407
Add RuntimeQml Package #13407
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It depends on conan-io/conan-docker-tools#466 |
This is my first contribution - It seems like the build failed because the conancenter binaries for Qt don't include ones that have QML enabled. Is there a way to build those or does this PR block building them? Also - should qt be set to shared as default? It makes a lot of sense for this package, but I might misunderstand. |
No. Only shared, fPIC and header_only are configured, any custom option only consumes its default value. More info: /~https://github.com/conan-io/conan-center-index/blob/3f4ce2ebdf9ed24cf12b27de6358e63a30eb9a0b/docs/packaging_policy.md#options
No, there are many considerations like license and compatibility for ANY plaform, usually, static works better. Please, read #10096 |
In case you package requires options which are not available in Conan Center, they should be validated under def validate(self):
foo = self.dependencies["foo"]
if not foo.options.bar:
raise ConanInvalidConfiguration(f"{self.ref} requires option foo:bar=True") In the worst case, you will generate 0 packages, but your recipe will be available in Conan Center. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@uilianries Any idea on why the linting CI is failing? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cmake_layout(self) | ||
|
||
def requirements(self): | ||
if Version(self.version) <= "cci.20211220": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works 😱 did not even know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we don't use that weird american format, is much easier compare using year first. After all, it's only char value comparison
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird american format
Heck at least I get two birthday 😆 🍰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good, just two small nits
I'd also encourage sharing the cmake build script upstream for others
Specify library name and version: runtimeqml/latest
Requesting to add: RuntimeQml
This is a very useful tool when developing qml based applications, integrating with conan will enable projects to build with less configuration.