Native Integration for Running Unit Tests in CodeSandbox #445

gautamarora · 2018-01-12T02:31:05Z

What kind of change does this PR introduce?
This PR adds native integration of unit testing using jest packages as discussed in this issue

What is the current behavior?
Currently, there is no support for unit testing.

What is the new behavior?
For a project with unit tests, Code Sandbox will run those tests and show the results in a new Tests tab (next to the Console tab)

Feature Checklist (v1):

Checklist:

Documentation
Tests
Ready to be merged
Added myself to contributors table

gautamarora · 2018-01-12T02:37:16Z

👋 @CompuIves - as you mentioned here

But we should add functionality to specify globals. I can do this, so you can specify an object like this:

{
  it,
  expect,
  // etc
}

could you help add it, expect, describe, jestMock from runner to globals

gautamarora · 2018-01-12T02:43:20Z

packages/app/src/sandbox/compile.js

+    });
+
+    debug(`Test Evaluation time: ${Date.now() - tt}ms`);
+    dispatch({


@CompuIves - the messages being dispatched from here do not seem to be showing up for me in the handleMessage of Console/index.js

CompuIves · 2018-01-12T10:26:35Z

Great! I've added the globals 😄 . Implementation looks really good so far.

gautamarora · 2018-01-12T22:10:09Z

@CompuIves - I've created a new ~~TestManger~~ TestRunner class and we now have a nice api to run tests from compile...

let testRunner = manager.testRunner;
testRunner.resetResults();
testRunner.findTests(modules);
await testRunner.transpileTests();
let testResults = testRunner.runTests();
console.log(testResults);

Next, I will look into why the dispatch results are not making their way to the Console.

gautamarora · 2018-01-13T05:44:16Z

dispatching results to Console now works!

CompuIves · 2018-01-13T13:47:07Z

This is sooo cool! I love how clean it is. Do you need help with the tab for the tests in the DevTools? I could work on that in the meantime if that makes sense.

Also, do you have a test sandbox with test files? Would love to play with it a bit 😄

gautamarora · 2018-01-13T14:08:37Z

@CompuIves - Thank You!
Yes, I could use your help for the Tests tab, both in adding one and thinking through how it should render the test output. One of the amazing things about the Code Sandbox experience is how clean and intuitive the UI is. I was thinking that the Tests tab should reflect that as well. Maybe we think of the Tests tab as a beautiful intuitive & helpful test reporter. Please go ahead and spin your magic! 😄

Here are 2 test sandboxes that you can try out:
Simple sandbox with 1 file and 1 test: http://pr445.cs.lbogdan.tk/s/ll4nxm6olq
React Redux TodoMVC App (all tests pass!): http://pr445.cs.lbogdan.tk/s/github/reactjs/redux/tree/master/examples/todomvc

CompuIves · 2018-01-13T14:38:22Z

Maan this is so impressive!

I'll try my hand at the tab, it would be great if every test result had 2 extra properties: a property with an array called something like describe that specifies which describes it is in and a property called file with the file name. I want to try something with grouping the tests in the devtools.

gautamarora · 2018-01-13T14:51:19Z

@CompuIves - yes totally agree with grouping of tests using describe (right now i ignore describe but i can fix that easily) and with adding file names (not 100% sure how to do that, but will find a way).

gautamarora · 2018-01-15T18:58:11Z

@CompuIves - looks like all of the v1 functionality work for this is done. I will rebase this soon.

When you merge this to master, will you also be releasing a new version of the site, or is that only going to happen with v2.5 later? If this is not going to be released immediately after merging, then I can create another PR later to add test cases for the test runner.

In the meanwhile, let me know if you have any feedback on the code.

CompuIves · 2018-01-16T12:27:23Z

When you merge this to master, will you also be releasing a new version of the site, or is that only going to happen with v2.5 later? If this is not going to be released immediately after merging, then I can create another PR later to add test cases for the test runner.

It will be immediately released. I'll do a review now!

CompuIves

Code looks very good, clear and easy to read!

I left one question, also I think it's be best if the console.log comments are removed before merging. Other than that I'm eager to merge this!

CompuIves · 2018-01-16T12:28:35Z

packages/app/src/sandbox/eval/tests/jest-lite.js

+
+    let summaryEmoji =
+      aggregatedResults.totalTestSuites === aggregatedResults.passedTestSuites
+        ? '😎'


Hahaha I love this

CompuIves · 2018-01-16T12:29:00Z

packages/app/src/sandbox/eval/tests/jest-lite.js~HEAD

@@ -0,0 +1,210 @@
+// @flow


What's with this file?

yeah, not sure. checking.

CompuIves · 2018-01-16T12:29:12Z

packages/app/src/sandbox/eval/transpiled-module.js

@@ -661,7 +663,8 @@ export default class TranspiledModule {
        this.source.compiledCode,
        require,
        this.compilation,
-        manager.envVariables
+        manager.envVariables,
+        TestRunner.testGlobals()


gautamarora · 2018-01-16T12:35:15Z

@CompuIves - i removed the console logs and that odd file.

gautamarora · 2018-01-16T12:38:06Z

@CompuIves - what sort of documentation (if any for now) should I add. I can add Tests for this over the next few days if you are ok merging without them.

CompuIves · 2018-01-16T12:40:19Z

It would be great to have documentation ready for the 25th, you can create docs here: /~https://github.com/CompuIves/codesandbox-client/blob/master/packages/homepage/content/docs/. In the meantime we can merge it in 😄 .

Thank you very much for this immense help. This is a very big feature to have!

- Added support for nested describes - Added summary messages for test runs - Log failing tests with file path - Added support for finding tests in __tests__ -

CompuIves · 2018-01-16T12:53:33Z

Hmm, something strange happens with the jest test, I'm not sure why...

* upstream/master: Fix test Native Integration for Running Unit Tests in CodeSandbox (codesandbox#445)

gautamarora changed the title ~~Adding native integration for unit tests~~ [WIP] Adding native integration for unit tests Jan 12, 2018

gautamarora mentioned this pull request Jan 12, 2018

Running Unit Tests in CodeSandbox #364

Closed

gautamarora commented Jan 12, 2018

View reviewed changes

gautamarora changed the title ~~[WIP] Adding native integration for unit tests~~ [WIP] Native Integration for Running Unit Tests in CodeSandbox Jan 14, 2018

gautamarora force-pushed the master branch from 7b6c06f to 7a43417 Compare January 16, 2018 12:16

CompuIves approved these changes Jan 16, 2018

View reviewed changes

gautamarora changed the title ~~[WIP] Native Integration for Running Unit Tests in CodeSandbox~~ Native Integration for Running Unit Tests in CodeSandbox Jan 16, 2018

Arora and others added 10 commits January 16, 2018 07:43

Adding native integration for unit tests

9698fc5

Apply jest globals to evaluation

0a73093

Creating new Test Manager

7fff4f2

Hooking Test Runner up with Test Manager

0ea43be

Reset results in test manager on re-evaluation

7359165

Fixing calls to manager from test manager

23cef86

Fixing dispatch for test results to Console

bf44216

Renaming for clarity (jest-lite, test-runner)

d138e69

Fixing jest mock export

7c2a033

Update Console logging for test message + Find tests in __tests__

850eaeb

- Added support for nested describes - Added summary messages for test runs - Log failing tests with file path - Added support for finding tests in __tests__ -

gautamarora added 6 commits January 16, 2018 07:43

Fix for failed message count

82609ea

Moving globals to Test Runner class

32a9d85

Adding typescript support

53668ec

Fix manager

85d351a

Add test time to summary

ef1d187

Remove odd file

d2ac1a4

gautamarora force-pushed the master branch from c81e294 to d2ac1a4 Compare January 16, 2018 12:46

Adding myself to contributors

fdf4308

CompuIves merged commit ecf05f9 into codesandbox:master Jan 16, 2018

gautamarora added a commit to gautamarora/codesandbox-client that referenced this pull request Jan 16, 2018

Merge remote-tracking branch 'upstream/master'

30acaf4

* upstream/master: Fix test Native Integration for Running Unit Tests in CodeSandbox (codesandbox#445)

gautamarora mentioned this pull request Jan 16, 2018

Native Integration for Running Unit Tests in CodeSandbox - Fix #458

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Native Integration for Running Unit Tests in CodeSandbox #445

Native Integration for Running Unit Tests in CodeSandbox #445

gautamarora commented Jan 12, 2018 •

edited

Loading

gautamarora commented Jan 12, 2018

gautamarora Jan 12, 2018

CompuIves commented Jan 12, 2018

gautamarora commented Jan 12, 2018 •

edited

Loading

gautamarora commented Jan 13, 2018

CompuIves commented Jan 13, 2018

gautamarora commented Jan 13, 2018

CompuIves commented Jan 13, 2018

gautamarora commented Jan 13, 2018

gautamarora commented Jan 15, 2018 •

edited

Loading

CompuIves commented Jan 16, 2018

CompuIves left a comment

CompuIves Jan 16, 2018

CompuIves Jan 16, 2018

gautamarora Jan 16, 2018

CompuIves Jan 16, 2018

gautamarora commented Jan 16, 2018

gautamarora commented Jan 16, 2018

CompuIves commented Jan 16, 2018 •

edited

Loading

CompuIves commented Jan 16, 2018

Native Integration for Running Unit Tests in CodeSandbox #445

Native Integration for Running Unit Tests in CodeSandbox #445

Conversation

gautamarora commented Jan 12, 2018 • edited Loading

gautamarora commented Jan 12, 2018

gautamarora Jan 12, 2018

Choose a reason for hiding this comment

CompuIves commented Jan 12, 2018

gautamarora commented Jan 12, 2018 • edited Loading

gautamarora commented Jan 13, 2018

CompuIves commented Jan 13, 2018

gautamarora commented Jan 13, 2018

CompuIves commented Jan 13, 2018

gautamarora commented Jan 13, 2018

gautamarora commented Jan 15, 2018 • edited Loading

CompuIves commented Jan 16, 2018

CompuIves left a comment

Choose a reason for hiding this comment

CompuIves Jan 16, 2018

Choose a reason for hiding this comment

CompuIves Jan 16, 2018

Choose a reason for hiding this comment

gautamarora Jan 16, 2018

Choose a reason for hiding this comment

CompuIves Jan 16, 2018

Choose a reason for hiding this comment

gautamarora commented Jan 16, 2018

gautamarora commented Jan 16, 2018

CompuIves commented Jan 16, 2018 • edited Loading

CompuIves commented Jan 16, 2018

gautamarora commented Jan 12, 2018 •

edited

Loading

gautamarora commented Jan 12, 2018 •

edited

Loading

gautamarora commented Jan 15, 2018 •

edited

Loading

CompuIves commented Jan 16, 2018 •

edited

Loading