Native Integration for Running Unit Tests in CodeSandbox - Fix #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for nested describes - Added summary messages for test runs - Log failing tests with file path - Added support for finding tests in __tests__ -
* upstream/master: Fix test Native Integration for Running Unit Tests in CodeSandbox (codesandbox#445)
gautamarora
added a commit
to gautamarora/codesandbox-client
that referenced
this pull request
Jan 17, 2018
* 'master' of /~https://github.com/CompuIves/codesandbox-client: Fix tests causing sandbox to infinite reload Fix NPE Update Select.js (codesandbox#461) Native Integration for Running Unit Tests in CodeSandbox - Fix (codesandbox#458) update `README.md` to include link for phoneix framework (codesandbox#459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR refactors the TestRunner setup introduced in #445 for Unit Testing and removes the circular dependencies.
What is the current behavior?
yarn testfails withSuper expression must either be null or a function, not undefined.What is the new behavior?
testGlobalswas converted from static class method to an instance method;testGlobalsis now used intranspiled-module.jsvia the Manager.TestRunner instance.Checklist: