-
Notifications
You must be signed in to change notification settings - Fork 54
duffle relocate for thick bundles #705
Comments
One thing I'd like to do is figure out if we would need to separate out the command with a switch namespace or something else that'll indicate this is for OCI images and the associated registry. So to fully relocate a fancy thick bundle with all 3 like below it would be
OR 'duffle relocate thickbundle.tgz path/to/relocated.json --input-bundle-is-file --output-bundle-is-file --lambda-s3-bucket=lambda/functions --vm-blob-container=mydisks --repository --prefix=example.com/user' Does that sound like a reasonable approach? I don't want to explode complexity in branching if it's better to just have |
@GreenCee I agree that needs figuring out in due course. Maybe the minimal support required for this issue is to fail the command when an image type other than oci or docker is encountered. Then when we figure out the way we want to support other image types, probably for a whole set of commands such as import, export, push, pull, relocate, etc., we can implement a backwards compatible change to Does that seem reasonable? |
I assumed it was. |
Broadened the scope of this issue to thick bundles containing just oci and docker images in either tar files or an OCI image layout. |
TODO: See FIXME(glyn in PR741) Fixes cnabio#705
TODO: See FIXME(glyn in PR741) Fixes cnabio#705
TODO: See FIXME(glyn in PR741) Fixes cnabio#705
TODO: See FIXME(glyn in PR741) Fixes cnabio#705
TODO: See FIXME(glyn in PR741) Fixes cnabio#705
Now that thick bundles store images in OCI image layouts only, we no longer need to support storage of images in tar files. Also, we should support relocation mapping files (see cnabio/cnab-spec#195 and #778). |
Rough first cut - currently fails some unit tests. Fixes cnabio#705
Rough first cut - currently fails some unit tests. Fixes cnabio#705
The scope of this issue is to extend duffle relocate to relocate oci and docker images from a thick bundle.
Example usage:
Note that the output is a thin bundle: the images will reside in repositories and do not need to be kept in the output bundle.
The text was updated successfully, but these errors were encountered: