This repository has been archived by the owner on May 3, 2022. It is now read-only.
duffle relocate of thick bundles #783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Communicating with kubernetes clusters that use auth plugins require that support for the auth plugin be compiled into the go binary. This PR adds support for all auth plugins provided by k8s.io/client-go. Without this change, attempting to use the k8s driver with GKE results in a panic like: ``` panic: No Auth Provider found for name "gcp" goroutine 1 [running]: github.com/deislabs/duffle/pkg/driver.(*KubernetesDriver).SetConfig(0xc0002f6000, 0xc000285470) /go/src/github.com/deislabs/duffle/pkg/driver/kubernetes.go:89 +0x317 main.prepareDriver(0x7ffc395ceb4d, 0x3, 0xc000549800, 0x5, 0xc0005480e0, 0xd) /go/src/github.com/deislabs/duffle/cmd/duffle/main.go:111 +0x204 main.(*installCmd).run(0xc00013f4a0, 0x12, 0x0) /go/src/github.com/deislabs/duffle/cmd/duffle/install.go:115 +0x246 main.newInstallCmd.func1(0xc0002a6780, 0xc000297b20, 0x2, 0x7, 0x0, 0x0) /go/src/github.com/deislabs/duffle/cmd/duffle/install.go:80 +0xa5 github.com/deislabs/duffle/vendor/github.com/spf13/cobra.(*Command).execute(0xc0002a6780, 0xc000297ab0, 0x7, 0x7, 0xc0002a6780, 0xc000297ab0) /go/src/github.com/deislabs/duffle/vendor/github.com/spf13/cobra/command.go:762 +0x473 github.com/deislabs/duffle/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc00028e500, 0xc000542f00, 0xc0000506f0, 0xc0000507a0) /go/src/github.com/deislabs/duffle/vendor/github.com/spf13/cobra/command.go:852 +0x2fd github.com/deislabs/duffle/vendor/github.com/spf13/cobra.(*Command).Execute(0xc00028e500, 0x0, 0xc00028e500) /go/src/github.com/deislabs/duffle/vendor/github.com/spf13/cobra/command.go:800 +0x2b main.main() /go/src/github.com/deislabs/duffle/cmd/duffle/main.go:31 +0x47 ```
* duffle relocate creates relocation mapping file Ref cnabio#772 * Accept relocation mapping file on install, upgrade, and run Fixes cnabio#772 * Address review comments
…io#788) * Synchronize with cnab-go master branch and adapt the code and tests to reflect the Bundle structure changes (Split parameters into parameters and definition, added JSON Schema support, replaced bundle.Location by bundle.Credential) Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com> * Set a dependency constraint on cnab-go v0.1.2-beta1 Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
Add auth plugings for k8s driver
Copy the version and schemaVersion from manifest to bundle. Initialize the manifest with a valid schemaVersion
glyn
force-pushed
the
705-thick-bundle-relocation-with-relocation-mapping-files
branch
from
c4ea891 to
4c307f6
Compare
glyn
changed the title
|
Closing in favour of #782. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #705