Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asterisks to required fields #4869

Merged
merged 9 commits into from
Sep 9, 2021
Merged

Add asterisks to required fields #4869

merged 9 commits into from
Sep 9, 2021

Conversation

KarolDawidziuk
Copy link
Contributor

What is the purpose of this pull request?

New feature

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

* [#3433>](/~https://github.com/ckeditor/ckeditor4/issues/3433): [dialog]: Added asterisks to required fields.

What changes did you make?

I've added asterisks to each required label in the dialogs.

Which issues does your PR resolve?

Closes #3433.

@jacekbogdanski jacekbogdanski self-requested a review September 8, 2021 08:58
Copy link
Member

@jacekbogdanski jacekbogdanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a manual test confirming that the feature works correctly for different editor skins (required once you move inlined CSS). You can just use some existing feature dialog like image, table, etc

tests/plugins/dialogui/required.js Outdated Show resolved Hide resolved
plugins/dialogui/plugin.js Outdated Show resolved Hide resolved
@KarolDawidziuk
Copy link
Contributor Author

Thanks @jacekbogdanski for the review!
It's ready for another one.

Changes:

  • Added custom CSS class instead of inline style.
  • Updated unit tests.
  • Added manual tests.

Copy link
Member

@jacekbogdanski jacekbogdanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍🏻

plugins/dialogui/plugin.js Outdated Show resolved Hide resolved
skins/kama/dialog.css Outdated Show resolved Hide resolved
skins/moono-lisa/dialog.css Outdated Show resolved Hide resolved
skins/moono/dialog.css Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some dialog fields are not visually marked as required
2 participants