Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some dialog fields are not visually marked as required #3433

Closed
f1ames opened this issue Sep 18, 2019 · 2 comments · Fixed by #4869
Closed

Some dialog fields are not visually marked as required #3433

f1ames opened this issue Sep 18, 2019 · 2 comments · Fixed by #4869
Assignees
@KarolDawidziuk
Labels
accessibility Issue related to accessibility. plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:feature A feature request.
Milestone
4.17.0

Comments

@f1ames
Copy link
Contributor

f1ames commented Sep 18, 2019 •
edited
Loading

Type of report

Bug

Provide detailed reproduction steps (if any)

Some dialog fields are not visually marked as required, for example Anchor Name in Anchor dialog:

  1. Go to any CKEditor 4 instance with link plugin.
  2. Open Anchor dialog.

Expected result

For keyboard users there should be "*" mark that is required field for "Anchor Name" edit box.

Actual result

When keyboard users navigate "Anchor Name" edit box , there is no required field that is "*" mark .But while navigating using screen reader it is announcing it as a required field.

image

Other details

  • Browser: All
  • OS: All
  • CKEditor version: 4.5+
  • Installed CKEditor plugins: -
@f1ames f1ames added type:bug A bug. support An issue reported by a commercially licensed client. plugin:link The plugin which probably causes the issue. target:minor Any docs related issue that can be merged into a master or major branch. accessibility Issue related to accessibility. support:2 An issue reported by a commercially licensed client. and removed support An issue reported by a commercially licensed client. labels Sep 18, 2019
@Comandeer
Copy link
Member

Actually we have more such dialogs, e.g. in "Flash" one we also don't mark URL field as required. Probably it would be better to check all dialogs for such omissions.

@Dumluregn Dumluregn added the status:confirmed An issue confirmed by the development team. label Sep 19, 2019
@f1ames f1ames changed the title Anchor Name field is not marked as required Some dialog fields are not visually marked as required Sep 19, 2019
@f1ames f1ames added plugin:dialog The plugin which probably causes the issue. and removed plugin:link The plugin which probably causes the issue. labels Sep 19, 2019
@f1ames f1ames removed the target:minor Any docs related issue that can be merged into a master or major branch. label Nov 12, 2019
@jacekbogdanski jacekbogdanski added size:S type:feature A feature request. and removed type:bug A bug. labels Sep 1, 2021
@jacekbogdanski jacekbogdanski mentioned this issue Sep 1, 2021
Closed
@KarolDawidziuk KarolDawidziuk self-assigned this Sep 3, 2021
@KarolDawidziuk KarolDawidziuk mentioned this issue Sep 6, 2021
Merged
3 tasks
@CKEditorBot
Copy link
Collaborator

Closed in #4869

@CKEditorBot CKEditorBot added this to the 4.17.0 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KarolDawidziuk KarolDawidziuk

Labels
accessibility Issue related to accessibility. plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:feature A feature request.
Projects
None yet
Milestone
4.17.0
Development

Successfully merging a pull request may close this issue.

Add asterisks to required fields ckeditor/ckeditor4
6 participants
@f1ames @Comandeer @jacekbogdanski @Dumluregn @KarolDawidziuk @CKEditorBot