Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Angular docs and samples after removing 'divarea' editor type #325

Merged
merged 10 commits into from
Sep 24, 2020
Merged

Update Angular docs and samples after removing 'divarea' editor type #325

merged 10 commits into from
Sep 24, 2020

Conversation

Dumluregn
Copy link
Contributor

Docs update for ckeditor/ckeditor4-angular#130.

Should be merged when ckeditor/ckeditor4-angular#133 will be released.

Also closes ckeditor/ckeditor4#4125 and partially ckeditor/ckeditor4#3821.

@Dumluregn Dumluregn mentioned this pull request Sep 15, 2020
Closed
@f1ames
Copy link
Contributor

f1ames commented Sep 16, 2020

Ok, so let's wait until Angular integration 2.0.0 is on NPM (hopefully this/next week) and then we can get back to this PR ⏳

@f1ames f1ames self-requested a review September 21, 2020 13:02
@f1ames f1ames self-assigned this Sep 21, 2020
@f1ames
Copy link
Contributor

f1ames commented Sep 21, 2020

Ok, so let's wait until Angular integration 2.0.0 is on NPM (hopefully this/next week) and then we can get back to this PR

2.0.0 integration version is not on NPM yet but it doesn't block us from reviewing this PR. The only thing to check before merging is if examples works with latest version.

f1ames
f1ames approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Added some more info on divarea usage in 2.0.0 and earlier versions.

@f1ames f1ames requested a review from AnnaTomanek September 21, 2020 13:05
@AnnaTomanek AnnaTomanek requested a review from godai78 September 21, 2020 13:06
godai78
godai78 approved these changes Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@godai78 godai78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes only.

AnnaTomanek
AnnaTomanek approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@AnnaTomanek AnnaTomanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions added, looks fine otherwise! 👍

docs/guide/dev/integration/angular/README.md Outdated Show resolved Hide resolved
docs/guide/dev/integration/angular/README.md Outdated Show resolved Hide resolved
docs/guide/dev/integration/angular/README.md Outdated Show resolved Hide resolved
docs/sdk/examples/angular.html Outdated Show resolved Hide resolved
@f1ames
Copy link
Contributor

f1ames commented Sep 24, 2020 •
edited
Loading

Rebased onto latest stable.

@f1ames f1ames merged commit 124296b into stable Sep 24, 2020
@f1ames f1ames deleted the t/angular/127 branch September 24, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godai78 godai78 godai78 approved these changes

@f1ames f1ames f1ames approved these changes

@AnnaTomanek AnnaTomanek AnnaTomanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary indentation in Angular code samples
4 participants
@Dumluregn @f1ames @AnnaTomanek @godai78