Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate divarea editor type #130

Closed
Dumluregn opened this issue Aug 18, 2020 · 1 comment · Fixed by #133
Closed

Deprecate divarea editor type #130

Dumluregn opened this issue Aug 18, 2020 · 1 comment · Fixed by #133
Assignees
@Dumluregn
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).

Comments

@Dumluregn
Copy link
Collaborator

Are you reporting a feature request or a bug?

Task

Details

Follow-up of #127 - as mentioned in #127 (comment), divarea is not really an editor type and it isn't present in other integrations, so we should depracate it to have consistent API between frameworks. This is a breaking change, so it should be included in a major (probably 2.0.0) release and require some additional work (e.g. in docs)
@Dumluregn Dumluregn added status:confirmed An issue confirmed by the development team. workload:medium type:task Any other issue (refactoring, typo fix, etc). labels Aug 18, 2020
This was referenced Sep 9, 2020
Merged
Closed
@Dumluregn Dumluregn self-assigned this Sep 14, 2020
@Dumluregn
Copy link
Collaborator Author

Dumluregn commented Sep 14, 2020 •
edited
Loading

PR in integration repo: #133
PR in docs: ckeditor/ckeditor4-docs#325

readme files in repo and npm don't need an update.

@Dumluregn Dumluregn mentioned this issue Sep 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dumluregn Dumluregn

Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up editor types ckeditor/ckeditor4-angular
1 participant
@Dumluregn