Fix value stored in element options for indexable option #860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #801 introduced indexable options (
font
andcolor
).The current options resolution is checking if the options is indexable and if true, it stores the value of the options.
chartjs-plugin-annotation/src/elements.js
Line 134 in bc38d6b
In this way, it stores a
Proxy
object (or an array ofProxy
) in element options, something that probably you don't want.This PR is storing "plain" objects as
element.options
.