Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable different fonts and colors configuration on multiline labels #801

Merged
merged 48 commits into from
Feb 25, 2023
Merged

Enable different fonts and colors configuration on multiline labels #801

merged 48 commits into from
Feb 25, 2023

Conversation

stockiNail
Copy link
Collaborator

@stockiNail stockiNail commented Sep 29, 2022

fix #739

contentMultilineColors

TODO

  • test cases
  • types definitions changes
  • documentation
  • samples

@stockiNail stockiNail added this to the 2.1.0 milestone Sep 29, 2022
@stockiNail stockiNail marked this pull request as ready for review September 30, 2022 16:01
src/elements.js Outdated Show resolved Hide resolved
@stockiNail stockiNail requested a review from kurkle October 27, 2022 11:22
@stockiNail stockiNail modified the milestones: 2.1.0, 2.2.0 Nov 17, 2022
kurkle
kurkle previously approved these changes Feb 24, 2023
@kurkle
Copy link
Member

kurkle commented Feb 24, 2023

Needs a rebase

@stockiNail
Copy link
Collaborator Author

stockiNail commented Feb 24, 2023

Needs a rebase

Done but fighting with fixture tests on FF... Don't know why. Locally no issue with the same FF version 110.0

@kurkle
Copy link
Member

kurkle commented Feb 24, 2023

I'm not able to help this weekend, except on reviews.

@stockiNail
Copy link
Collaborator Author

I'm not able to help this weekend, except on reviews.

No problem. I will leave it as is now. I need to understand better why the fixture tests are all failing only on FF and only in CI (not locally). I'll have a look next week, busy this weekend as well.

@kurkle
Copy link
Member

kurkle commented Feb 24, 2023

Maybe the animations got enabled for ci?

@stockiNail
Copy link
Collaborator Author

stockiNail commented Feb 24, 2023

Maybe the animations got enabled for ci?

I don't think so.. I'm thinking (but not sure) it could be related to #851, where the point location calculation changed but it's also weird that I didn't have these errors in that PR.

EDIT rollback the changes where tolerance was added. More investigations are needed

@stockiNail
Copy link
Collaborator Author

No way, even re-saving the image from FF (v110.0, like in CI) and push it. I don't where the issue could be :(

@stockiNail
Copy link
Collaborator Author

@kurkle rebased and CI ended correctly.

@stockiNail stockiNail merged commit b9cbccf into chartjs:master Feb 25, 2023
@stockiNail stockiNail deleted the fontsColors branch February 25, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply different font to each line in label annotation options
2 participants