✨ Set default emoji format to emoji #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default emoji format was originally set to `code` for the following reason: > The reason behind this was to be able to use the shortcode to favour > the readability on certain terminals that do not support Emojis! > @carloscuesta Terminals are considerably more advanced on all platforms and the standard Gitmoji set is simple enough that all terminals would display them correctly nowadays. This change updates the default format from `code` to `emoji`. The benefits of this change: - Improve display of emojis in commit titles, pull request titles and list of pull requests on some remote repository providers. - Removes need to modify the pager to allow `git log` to display emojis. Issue: #1247 Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
3 tasks
|
@carloscuesta Can you approve this workflow? Thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1248 +/- ##
=======================================
Coverage 91.75% 91.75%
=======================================
Files 28 28
Lines 279 279
Branches 66 66
=======================================
Hits 256 256
Misses 22 22
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default emoji format was originally set to
codefor the following reason:Terminals are considerably more advanced on all platforms and the standard Gitmoji set is simple enough that all terminals would display them correctly nowadays.
This change updates the default format from
codetoemoji.The benefits of this change:
Improve display of emojis in commit titles, pull request titles and list of pull requests on some remote repository providers.
Removes need to modify the pager to allow
git logto display emojis.Fixes: #1247