-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review default emoji format #1247
Comments
@carloscuesta Any thoughts on this proposal? |
Hey! Thanks for opening the issue 8 years ago already your comment made me feel old 🤣 |
Pull request #1248 created making this change. Unit tests pass successfully and deleting my global config and creating a new one with |
The default emoji format was originally set to `code` for the following reason: > The reason behind this was to be able to use the shortcode to favour > the readability on certain terminals that do not support Emojis! > @carloscuesta Terminals are considerably more advanced on all platforms and the standard Gitmoji set is simple enough that all terminals would display them correctly nowadays. This change updates the default format from `code` to `emoji`. The benefits of this change: - Improve display of emojis in commit titles, pull request titles and list of pull requests on some remote repository providers. - Removes need to modify the pager to allow `git log` to display emojis. Issue: #1247 Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
Discussion
There are significant inconsistencies with some Git remote repository providers such as BitBucket when displaying Emoji shortcodes. BitBucket does display shortcodes for the commit title, but not the PR title and list of PRs.
There is also requirement to modify the pager (or other tricks) to allow
git log
to display correctly.After investigation it became clear for the reasoning why shortcodes were chosen as the default.
While the decision may have been appropriate 8 year ago when
gitmoji-cli
was first released, it does beg the question, is it worth considering changing the default behaviour now?Terminals are considerably more advanced on all platforms and the standard Gitmoji set is simple enough that all terminals would display them correctly nowadays. I am at a loss to come up with any other reason to keep the shortcode format as the default.
As someone who has developed their own implementation of
gitmoji-cli
, I still aim to maintain consistency and so have kept the shortcode format the default for my CLI tool as well. However, I think it may be now worth reviewing this decision and seeing ifemoji
makes more sense going forward.Validations
The text was updated successfully, but these errors were encountered: