Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VEP csqs in impact categories to match VEP #703

Merged
merged 2 commits into from
May 24, 2024

Conversation

mike-w-wilson
Copy link
Contributor

This moves start_lost from medium to high impact and splice_region_variant from medium to low impact. These match the current ensembl table.

Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment update then LGTM!

@@ -30,20 +30,20 @@
"stop_gained",
"frameshift_variant",
"stop_lost",
"start_lost", # Considered high impact in v105, previously medium
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it won't let me comment above, but lines 24-25 say:

# Note that this is the current as of v81 with some included for backwards
# compatibility (VEP <= 75)

how about

# Note that this is the current as of v105 with some included for backwards
# compatibility (VEP <= 75)
# See: https://www.ensembl.org/info/genome/variation/prediction/predicted_data.html

@mike-w-wilson mike-w-wilson merged commit 03dd554 into main May 24, 2024
5 checks passed
@mike-w-wilson mike-w-wilson deleted the mw/vep_105_csq_impact_update branch May 24, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants