Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic_field_check in validity_checks.py print of failed checks #693

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

jkgoodrich
Copy link
Contributor

When checks are failing, generic_field_check is printing a show() of the first rows of the input HT instead of the first few rows that are failing the check

Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- added checks and bonus easier to read!

gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Show resolved Hide resolved
@jkgoodrich jkgoodrich merged commit 77c9f60 into main Apr 16, 2024
3 checks passed
@jkgoodrich jkgoodrich deleted the jg/validity_check_fail_print_fix branch April 16, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants