Add optional parameters to set_female_y_metrics_to_na_expr to use other frequency fields
#635
Conversation
…ther frequency fields
| @@ -1046,31 +1046,45 @@ def missing_callstats_expr() -> hl.expr.StructExpression: | |||
|
|
|||
|
|
|||
| def set_female_y_metrics_to_na_expr( | |||
| t: Union[hl.Table, hl.MatrixTable] | |||
| t: Union[hl.Table, hl.MatrixTable], | |||
There was a problem hiding this comment.
it would be a breaking change, but we could avoid passing in a Table or MatrixTable if freq_expr, freq_meta_expr, and freq_index_dict_expr only accept HailExpressions, right?
There was a problem hiding this comment.
yeah, but I don't feel like going through an changing the things that we already ran this release that use that, I think it's cleaner to just leave as is for the next pypi release
|
|
||
| :param t: Table or MatrixTable for which to adjust female metrics | ||
| :return: Hail array expression to set female Y-variant metrics to missing values | ||
| """ | ||
| female_idx = hl.map( |
There was a problem hiding this comment.
maybe we should make this
xx_idx = hl.map(
since we've been moving away from using gender terms for our sex assignments (though I guess maybe we should rename the function also, which is also a breaking change)
There was a problem hiding this comment.
I think this is a post v4 change, we can do an overhaul for that and population
No description provided.