Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function to remove items from freq and freq_meta #582

Merged
merged 15 commits into from
Aug 28, 2023
Merged

function to remove items from freq and freq_meta #582

merged 15 commits into from
Aug 28, 2023

Conversation

KoalaQin
Copy link
Contributor

Script to remove items from the freq array and freq_meta array in the Table.

@KoalaQin KoalaQin requested a review from jkgoodrich August 24, 2023 13:53
@KoalaQin KoalaQin marked this pull request as draft August 24, 2023 16:33
@KoalaQin KoalaQin marked this pull request as ready for review August 25, 2023 09:52
jkgoodrich
jkgoodrich requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions and requests for additional features

gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
@KoalaQin KoalaQin requested a review from jkgoodrich August 25, 2023 16:40
jkgoodrich
jkgoodrich requested changes Aug 25, 2023
View reviewed changes
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
@KoalaQin KoalaQin requested a review from jkgoodrich August 25, 2023 20:15
jkgoodrich
jkgoodrich requested changes Aug 28, 2023
View reviewed changes
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
@KoalaQin KoalaQin requested a review from jkgoodrich August 28, 2023 19:05
jkgoodrich
jkgoodrich requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple things. It looks like some of my suggestions from the last round were marked as resolved, but had not been changed in the PR

gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
@KoalaQin
Copy link
Contributor Author

KoalaQin commented Aug 28, 2023 •
edited
Loading

It was because of my weird Pycharm today. It's not syncing.

@KoalaQin KoalaQin requested a review from jkgoodrich August 28, 2023 19:33
jkgoodrich
jkgoodrich approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KoalaQin KoalaQin merged commit 7095e94 into main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkgoodrich jkgoodrich jkgoodrich approved these changes

Assignees

@jkgoodrich jkgoodrich

@KoalaQin KoalaQin

Labels
annotation Changelog: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KoalaQin @jkgoodrich