Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an n_pcs option to run_platform_pca #468

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Add an n_pcs option to run_platform_pca #468

merged 1 commit into from
Jul 18, 2022

Conversation

jkgoodrich
Copy link
Contributor

run_platform_pca currently has no option to change the number of PCs to compute

@jkgoodrich jkgoodrich requested a review from mike-w-wilson July 18, 2022 19:16
mike-w-wilson
mike-w-wilson approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkgoodrich jkgoodrich merged commit 4992027 into main Jul 18, 2022
@jkgoodrich jkgoodrich deleted the jg/add_platform_pca_n_pcs branch July 18, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-w-wilson mike-w-wilson mike-w-wilson approved these changes

Assignees
No one assigned
Labels
Changelog: new feature Unplanned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkgoodrich @mike-w-wilson