Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add checkpoint option to get_qc_mt #437

Merged
merged 4 commits into from
Jan 25, 2022
Merged

add checkpoint option to get_qc_mt #437

merged 4 commits into from
Jan 25, 2022

Conversation

klaricch
Copy link
Contributor

No description provided.

@klaricch klaricch requested a review from jkgoodrich January 25, 2022 16:18
jkgoodrich
jkgoodrich requested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting a couple loggers, and addition to docstring params. Thanks for adding!

gnomad/sample_qc/pipeline.py Outdated Show resolved Hide resolved
gnomad/sample_qc/pipeline.py Show resolved Hide resolved
gnomad/sample_qc/pipeline.py Show resolved Hide resolved
@klaricch klaricch requested a review from jkgoodrich January 25, 2022 16:42
jkgoodrich
jkgoodrich requested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny changes

gnomad/sample_qc/pipeline.py Outdated Show resolved Hide resolved
gnomad/sample_qc/pipeline.py Outdated Show resolved Hide resolved
gnomad/sample_qc/pipeline.py Outdated Show resolved Hide resolved
klaricch and others added 2 commits January 25, 2022 11:54
@klaricch @jkgoodrich
Apply suggestions from code review
c1cf5ff 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch
move line up
3e021b2
@klaricch klaricch requested a review from jkgoodrich January 25, 2022 16:56
jkgoodrich
jkgoodrich approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@klaricch klaricch merged commit b955780 into master Jan 25, 2022
@klaricch klaricch deleted the qc_mt branch January 25, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkgoodrich jkgoodrich jkgoodrich approved these changes

Assignees
No one assigned
Labels
Changelog: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klaricch @jkgoodrich