Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vds resource #423

Merged
merged 6 commits into from
Dec 1, 2021
Merged

add vds resource #423

merged 6 commits into from
Dec 1, 2021

Conversation

klaricch
Copy link
Contributor

No description provided.

@klaricch klaricch requested a review from jkgoodrich November 18, 2021 14:28
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things

gnomad/resources/resource_utils.py Show resolved Hide resolved
gnomad/resources/resource_utils.py Outdated Show resolved Hide resolved
gnomad/resources/resource_utils.py Show resolved Hide resolved
gnomad/resources/resource_utils.py Outdated Show resolved Hide resolved
gnomad/resources/resource_utils.py Show resolved Hide resolved
gnomad/resources/resource_utils.py Show resolved Hide resolved
gnomad/resources/resource_utils.py Show resolved Hide resolved
@jkgoodrich
Copy link
Contributor

Also, I think you need to run Black

klaricch and others added 2 commits November 29, 2021 13:21
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch klaricch requested a review from jkgoodrich November 29, 2021 18:42
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from the pylint failure

@nawatts
Copy link
Contributor

nawatts commented Nov 30, 2021

The Pylint failure is resolved in #425.

@klaricch klaricch merged commit 30f6812 into master Dec 1, 2021
@klaricch klaricch deleted the vds_resource branch December 1, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants