Changed or to and in set_female_metrics_to_na #347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function previously was not correctly setting metrics to missing on chrY (XX samples only). For example:
y_par
is an annotation showing whether the locus is in a pseudoautosomal region of chromosome Yy_nonpar
is an annotation showing whether the locus is in a non-pseudoautosomal region of chromosome Yy_conds
is an annotation with the following condition:(~locus.in_y_nonpar() | ~locus.in_y_par())
ac_xx_adj
should be NA on both lines, but you can see that on both lines,y_conds
evaluates to True, which means line 779 will return the original value of this metric (and not missing).