Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary stats #285

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Summary stats #285

merged 6 commits into from
Jan 26, 2021

Conversation

ch-kr
Copy link
Contributor

@ch-kr ch-kr commented Jan 22, 2021

@ch-kr ch-kr requested a review from jkgoodrich January 22, 2021 17:08
jkgoodrich
jkgoodrich requested changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just a few things

gnomad/assessment/summary_stats.py Outdated Show resolved Hide resolved
gnomad/assessment/summary_stats.py Outdated Show resolved Hide resolved
gnomad/assessment/summary_stats.py Outdated Show resolved Hide resolved
gnomad/assessment/summary_stats.py Outdated Show resolved Hide resolved
gnomad/assessment/summary_stats.py Outdated Show resolved Hide resolved
gnomad/assessment/summary_stats.py Outdated Show resolved Hide resolved
gnomad/assessment/summary_stats.py Show resolved Hide resolved
gnomad/assessment/summary_stats.py Outdated Show resolved Hide resolved
gnomad/utils/vep.py Outdated Show resolved Hide resolved
gnomad/utils/vep.py Outdated Show resolved Hide resolved
@ch-kr ch-kr requested a review from jkgoodrich January 26, 2021 20:34
jkgoodrich
jkgoodrich approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, one extremely tiny request

gnomad/assessment/summary_stats.py Outdated Show resolved Hide resolved
@jkgoodrich jkgoodrich merged commit 364160e into master Jan 26, 2021
@jkgoodrich jkgoodrich deleted the summary_stats branch January 26, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkgoodrich jkgoodrich jkgoodrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ch-kr @jkgoodrich