OriginInfo for TransactionInfo #12987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
supermassive
force-pushed
the
OriginInfoForTransactionInfo
branch
from
233586b to
ec1f7fb
Compare
supermassive
commented
Apr 13, 2022
| defaultCurrencies, | ||
| selectedPendingTransaction: transactionInfo | ||
| } = useSelector(({ wallet }: { wallet: WalletState }) => wallet) | ||
|
|
||
| const originInfo = transactionInfo?.originInfo ?? activeOrigin |
There was a problem hiding this comment.
"Legacy" transactions coming from prefs won't have originInfo(hence it is optional). Falling back to activeOrigin as it worked before. But maybe that case should be presented in UI in some special way.
| @@ -655,10 +655,12 @@ export async function sendEthTransaction (store: Store, payload: SendEthTransact | |||
| gasEstimation: undefined | |||
| } | |||
| // @ts-expect-error google closure is ok with undefined for other fields but mojom runtime is not | |||
| addResult = await apiProxy.txService.addUnapprovedTransaction({ ethTxData1559: txData1559 }, payload.from) | |||
| const txDataUnion: BraveWallet.TxDataUnion = { ethTxData1559: txData1559 }; | |||
| addResult = await apiProxy.txService.addUnapprovedTransaction(txDataUnion, payload.from, null) | |||
There was a problem hiding this comment.
null here as last argument so chrome://wallet will be set as origin
supermassive
force-pushed
the
OriginInfoForTransactionInfo
branch
3 times, most recently
from
bd8ddb6 to
8f2e02e
Compare
supermassive
force-pushed
the
OriginInfoForTransactionInfo
branch
from
8f2e02e to
19f8b73
Compare
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#21915
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: