Store initiator origin info for DAPP requests #21915
Labels
feature/web3/wallet/core
feature/web3/wallet/dapps
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
We need to store initiator's origin for dapp requests that would prompt UI for user to confirm.
See
BraveWalletJSHandler::SendAsync
,BraveWalletJSHandler::Send
,BraveWalletJSHandler::Request
for entry points.See
BraveWalletProviderImpl::CommonRequestOrSendAsync
for how backend start to process different methods.Besides sendEthTransaction requests that would be get from pending transactions. UI get those pending requests in /~https://github.com/brave/brave-core/blob/master/components/brave_wallet_ui/panel/async/wallet_panel_async_handler.ts#L171-L194. We need to provide initiator's origin for all these DAPP requests to UI.
/~https://github.com/bbondy/eth-manual-tests and https://metamask.github.io/test-dapp/ might be useful for testing.
For QA:
Close bubble by clicking outside of it.
Bad:
Good:
The text was updated successfully, but these errors were encountered: