-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.20.2 Go dependency updates #3999
Conversation
sources/host-ctr/go.mod
Outdated
github.com/containerd/containerd v1.6.30 | ||
github.com/aws/aws-sdk-go v1.53.10 | ||
github.com/awslabs/amazon-ecr-containerd-resolver v0.0.0-20240521172427-b580afd02343 | ||
github.com/containerd/containerd v1.6.32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the past, we have not updated this library dependency without updating the package at /~https://github.com/bottlerocket-os/bottlerocket/blob/develop/packages/containerd/Cargo.toml to avoid any possible breaking changes between these two (even if that would be unlikely).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, will update the containerd Cargo.toml
with the url
and sha512
of the latest version. Along with the spec file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From our offline discussion, I'll be doing the Go updates in host-ctr
keeping containerd
locked at v1.6.30.
containerd
will be upgraded as part of a separate issue: #3876
Signed-off-by: Kush Upadhyay <kushupad@amazon.com>
Signed-off-by: Kush Upadhyay <kushupad@amazon.com>
Issue number: 3998
Closes #3998
Description of changes:
Updates to
host-ctr
andecs-gpu-init
packages:In
host-ctr
source packagego get -u github.com/containerd/containerd@v1.6.30 ./...
toolchain
version1.22.3
, so manually lowered it to1.22.2
Note: Could not update dependents of aws-sdk-go@v1.53.10 as this pulled in containerd v1.7.x. Also, keeping
containerd
locked at v1.6.30. This dependency will be upgraded as part of this issue: #3876In
ecs-gpu-init
source packagego get -u ./...
Testing done:
Builds for
aws-ecs-2
,aws-ecs-2-nvidia
,aws-k8s-1.30
variants succeed. ECS variant instances are able to connect to a cluster.Following tests done on
aws-ecs-2-nvidia
variant:host-ctr
ecs-gpu-init
:nvidia-smi
in a task on a GPU instance:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.