Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.2 Go dependency updates #3999

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

koooosh
Copy link
Contributor

@koooosh koooosh commented May 28, 2024

Issue number: 3998
Closes #3998

Description of changes:
Updates to host-ctr and ecs-gpu-init packages:

In host-ctr source package

  1. Ran go get -u github.com/containerd/containerd@v1.6.30 ./...
  2. Build was breaking for automatically updated toolchain version 1.22.3, so manually lowered it to 1.22.2

Note: Could not update dependents of aws-sdk-go@v1.53.10 as this pulled in containerd v1.7.x. Also, keeping containerd locked at v1.6.30. This dependency will be upgraded as part of this issue: #3876

In ecs-gpu-init source package

  1. Ran go get -u ./...

Testing done:
Builds for aws-ecs-2, aws-ecs-2-nvidia, aws-k8s-1.30 variants succeed. ECS variant instances are able to connect to a cluster.

Following tests done on aws-ecs-2-nvidia variant:

  • host-ctr
    • Verified control and admin containers load
    • Basic tooling: pulling, running, removing images
  • ecs-gpu-init:
    • Ran nvidia-smi in a task on a GPU instance:
-------------------------------------------------------------------------------------------------------------
|   timestamp   |                                          message                                          |
|---------------|-------------------------------------------------------------------------------------------|
| 1716922946653 | Tue May 28 19:02:26 2024                                                                  |
| 1716922946653 | +---------------------------------------------------------------------------------------+ |
| 1716922946653 | | NVIDIA-SMI 535.161.07             Driver Version: 535.161.07   CUDA Version: 12.2     | |
| 1716922946653 | |-----------------------------------------+----------------------+----------------------+ |
| 1716922946653 | | GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC | |
| 1716922946653 | | Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. | |
| 1716922946653 | |                                         |                      |               MIG M. | |
| 1716922946653 | |=========================================+======================+======================| |
| 1716922946662 | |   0  Tesla T4                       Off | 00000000:00:1E.0 Off |                    0 | |
| 1716922946662 | | N/A   32C    P0              26W /  70W |      2MiB / 15360MiB |      5%      Default | |
| 1716922946662 | |                                         |                      |                  N/A | |
| 1716922946662 | +-----------------------------------------+----------------------+----------------------+ |
| 1716922946662 |                                                                                           |
| 1716922946662 | +---------------------------------------------------------------------------------------+ |
| 1716922946662 | | Processes:                                                                            | |
| 1716922946662 | |  GPU   GI   CI        PID   Type   Process name                            GPU Memory | |
| 1716922946662 | |        ID   ID                                                             Usage      | |
| 1716922946662 | |=======================================================================================| |
| 1716922946662 | |  No running processes found                                                           | |
| 1716922946662 | +---------------------------------------------------------------------------------------+ |
-------------------------------------------------------------------------------------------------------------

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@koooosh koooosh self-assigned this May 28, 2024
@koooosh koooosh changed the title 1.20 go updates 1.20.1 Go dependency updates May 28, 2024
github.com/containerd/containerd v1.6.30
github.com/aws/aws-sdk-go v1.53.10
github.com/awslabs/amazon-ecr-containerd-resolver v0.0.0-20240521172427-b580afd02343
github.com/containerd/containerd v1.6.32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past, we have not updated this library dependency without updating the package at /~https://github.com/bottlerocket-os/bottlerocket/blob/develop/packages/containerd/Cargo.toml to avoid any possible breaking changes between these two (even if that would be unlikely).

Copy link
Contributor Author

@koooosh koooosh May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, will update the containerd Cargo.toml with the url and sha512 of the latest version. Along with the spec file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our offline discussion, I'll be doing the Go updates in host-ctr keeping containerd locked at v1.6.30.

containerd will be upgraded as part of a separate issue: #3876

@koooosh koooosh requested review from yeazelm and removed request for jpculp and jmt-lab May 28, 2024 21:45
koooosh added 2 commits June 1, 2024 02:49
Signed-off-by: Kush Upadhyay <kushupad@amazon.com>
Signed-off-by: Kush Upadhyay <kushupad@amazon.com>
@koooosh koooosh changed the title 1.20.1 Go dependency updates 1.20.2 Go dependency updates Jun 1, 2024
@koooosh koooosh force-pushed the 1.20-go-updates branch from 5719f5a to 96dc931 Compare June 1, 2024 02:57
@koooosh koooosh requested a review from KCSesh June 1, 2024 02:58
@koooosh koooosh merged commit 02be0b8 into bottlerocket-os:develop Jun 3, 2024
33 checks passed
@koooosh koooosh deleted the 1.20-go-updates branch June 4, 2024 01:54
@koooosh koooosh restored the 1.20-go-updates branch June 4, 2024 02:06
@koooosh koooosh deleted the 1.20-go-updates branch July 15, 2024 21:39
@vigh-m vigh-m mentioned this pull request Aug 1, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.20.1 Go dependency updates
4 participants