Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default variant to aws-k8s-1.19 #1394

Merged
merged 1 commit into from
Mar 17, 2021
Merged

update default variant to aws-k8s-1.19 #1394

merged 1 commit into from
Mar 17, 2021

Conversation

webern
Copy link
Contributor

@webern webern commented Mar 15, 2021

Make the build system's default variant aws-k8s-1.19, and update
documentation that refers to the previous default variant.

Issue number:

#1383

Description of changes:

Update the default variant to aws-k8s-1.19.

Testing done:

  • Built a variant without specifying which variant I wanted. The k8s 1.19 was the result. Ran it ssh'ed to it, checked /etc/os-release.
  • ran eksctl create cluster --config-file sample-eksctl.yaml and got a 1.19 cluster.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦘

@webern webern requested a review from tjkirch March 16, 2021 18:15
Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review more fully later, but I was paged in for this bit specifically :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@webern
Copy link
Contributor Author

webern commented Mar 16, 2021

webern force-pushed the webern:default-119 branch from 9adbbfc to 69aae80

Undo the previous push which was messed up.

@webern
Copy link
Contributor Author

webern commented Mar 16, 2021

webern force-pushed the webern:default-119 branch from 69aae80 to 1781b6a

Re-do the intended README change, with tjkirch's fixes.

sources/updater/updog/src/bin/updata.rs Outdated Show resolved Hide resolved
Make the build system's default variant aws-k8s-1.19, and update
documentation that refers to the previous default variant.
@webern webern merged commit 0812260 into bottlerocket-os:develop Mar 17, 2021
@webern webern deleted the default-119 branch March 17, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants