metricdog: respect proxy settings #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
changed the title
webern
changed the title
samuelkarp
reviewed
Feb 16, 2021
Link TODO to a tracking issue |
Rebase. |
etungsten
approved these changes
Feb 19, 2021
samuelkarp
approved these changes
Feb 20, 2021
Is this something we should fix? |
bcressey
approved these changes
Feb 20, 2021
Probably. It's not specific to proxy settings. A map key cannot be removed with the API. |
Use the proxy.env file to give HTTPS_PROXY and NO_PROXY values to metricdog. metricdog's HTTP client automatically picks these up and uses them.
reqwest does not support HTTPS_PROXY values that are not in URL format (i.e. if there is no protocol scheme). On Bottlerocket we expect an HTTPS_PROXY value with no scheme to be treated as http://. Here we check the HTTPS_PROXY value, and if it has no scheme we reset the value to prepend https://
Rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1298
Description of changes:
Use the
proxy.envfile to give proxy values to metricdog.A second commit provides a workaround for seanmonstar/reqwest#1176
Testing done:
192.168.57.178:8888and setnetwork.https-proxyto this value.network.no-proxyto["metrics.bottlerocket.aws"], observed the metricdog pings stopped arriving at the tinyproxy.network.no-proxyto[], observed the metricdog pings start arriving at the tinyproxy again.network.https-proxy(this value cannot be unset once it has been set). Observed that metricdog pings were working.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.