Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: respect proxy settings #1298

Closed
webern opened this issue Feb 2, 2021 · 1 comment
Closed

metrics: respect proxy settings #1298

webern opened this issue Feb 2, 2021 · 1 comment
Assignees
@webern
Labels
type/enhancement New feature or request

Comments

@webern
Copy link
Contributor

webern commented Feb 2, 2021

PR #1006 supports issue #1000

The PR was created before we had host proxy settings. Instead of overloading that existing PR, we will add support for proxy settings as a fast-follow. In the meantime, as a workaround, the metrics feature can be disabled.

What I'd like:

metricdog should respect settings.network.https-proxy and settings.network.no-proxy.
@webern webern self-assigned this Feb 2, 2021
@webern webern mentioned this issue Feb 4, 2021
Closed
@gregdek gregdek added priority/p0 type/enhancement New feature or request labels Feb 5, 2021
This was referenced Feb 15, 2021
Open
Merged
@webern
Copy link
Contributor Author

webern commented Mar 1, 2021

Done

@webern webern closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webern webern

Labels
type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregdek @webern