-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename apply_system_buffers to apply_deferred #8726
Conversation
You added a new example but didn't update the readme. Please run |
examples/ecs/apply_system_buffers.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file name needs to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change example module name to reflect renaming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change. I've always found it difficult to write succinct documentation surrounding system buffers.
Co-authored-by: JoJoJet <21144246+JoJoJet@users.noreply.github.com>
You added a new example but didn't update the readme. Please run |
1 similar comment
You added a new example but didn't update the readme. Please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a quick question though.
Co-authored-by: JoJoJet <21144246+JoJoJet@users.noreply.github.com>
Objective
apply_system_buffers
is an unhelpful name: it introduces a new internal-only conceptSolution
apply_system_buffers
to the more descriptiveapply_deferred
Changelog
apply_system_buffers
has been renamed toapply_deferred
, to more clearly communicate its intent and relation toDeferred
system parameters likeCommands
.Migration Guide
apply_system_buffers
has been renamed toapply_deferred
apply_system_buffers
method on theSystem
trait has been renamed toapply_deferred
is_apply_system_buffers
function has been replaced byis_apply_deferred
Executor::set_apply_final_buffers
is nowExecutor::set_apply_final_deferred
Schedule::apply_system_buffers
is nowSchedule::apply_deferred