Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lib-storage): pass requestChecksumCalculation as WHEN_REQUIRED #6800

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 15, 2025

Issue

Internal JS-5678

Description

Temporarily passes requestChecksumCalculation as WHEN_REQUIRED in E2E tests for Upload

Testing

Before

$ lib-storage> yarn test:e2e
...
 ❯ src/lib-storage.e2e.spec.ts (4) 2144ms
   ❯ @aws-sdk/lib-storage (4) 2143ms
     ❯ Upload (4) 1223ms
       × should upload in parts for input type bytes
       × should upload in parts for input type string 544ms
       × should upload in parts for input type Readable
...
 FAIL  src/lib-storage.e2e.spec.ts > @aws-sdk/lib-storage > Upload > should upload in parts for input type bytes
 FAIL  src/lib-storage.e2e.spec.ts > @aws-sdk/lib-storage > Upload > should upload in parts for input type string
 FAIL  src/lib-storage.e2e.spec.ts > @aws-sdk/lib-storage > Upload > should upload in parts for input type Readable
InvalidPart: One or more of the specified parts could not be found.  The part may not have been uploaded, or the specified entity tag may not match the part's entity tag.
...
 Test Files  1 failed (1)
      Tests  3 failed | 1 passed (4)

After

$ lib-storage> yarn test:e2e
...
 Test Files  1 passed (1)
      Tests  4 passed (4)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 15, 2025 03:18
@trivikr trivikr merged commit 08cad71 into aws:main Jan 15, 2025
2 checks passed
@trivikr trivikr deleted the test-lib-storage branch January 15, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants