Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib-storage): set ChecksumAlgorithm when calling CreateMPU #6802

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 15, 2025

Issue

Description

Sets ChecksumAlgorithm when calling CreateMPU

Testing

CI

E2E tests are successful

$ lib-storage> yarn test:e2e
...
 ✓ src/lib-storage.e2e.spec.ts (60) 61371ms
   ✓ @aws-sdk/lib-storage (60) 61371ms
     ✓ requestChecksumCalculation: undefined (20) 20190ms
       ✓ ChecksumAlgorithm: undefined (4) 3813ms
         ✓ should upload in parts for input type bytes 777ms
         ✓ should upload in parts for input type string 1224ms
         ✓ should upload in parts for input type Readable 695ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: SHA1 (4) 3875ms
         ✓ should upload in parts for input type bytes 745ms
         ✓ should upload in parts for input type string 1311ms
         ✓ should upload in parts for input type Readable 719ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: SHA256 (4) 3973ms
         ✓ should upload in parts for input type bytes 834ms
         ✓ should upload in parts for input type string 1297ms
         ✓ should upload in parts for input type Readable 725ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: CRC32 (4) 3762ms
         ✓ should upload in parts for input type bytes 777ms
         ✓ should upload in parts for input type string 1241ms
         ✓ should upload in parts for input type Readable 706ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: CRC32C (4) 4766ms
         ✓ should upload in parts for input type bytes 992ms
         ✓ should upload in parts for input type string 1610ms
         ✓ should upload in parts for input type Readable 929ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload. 374ms
     ✓ requestChecksumCalculation: WHEN_REQUIRED (20) 21424ms
       ✓ ChecksumAlgorithm: undefined (4) 4016ms
         ✓ should upload in parts for input type bytes 802ms
         ✓ should upload in parts for input type string 1239ms
         ✓ should upload in parts for input type Readable 727ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload. 326ms
       ✓ ChecksumAlgorithm: SHA1 (4) 4287ms
         ✓ should upload in parts for input type bytes 959ms
         ✓ should upload in parts for input type string 1478ms
         ✓ should upload in parts for input type Readable 789ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: SHA256 (4) 4163ms
         ✓ should upload in parts for input type bytes 869ms
         ✓ should upload in parts for input type string 1392ms
         ✓ should upload in parts for input type Readable 809ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: CRC32 (4) 4047ms
         ✓ should upload in parts for input type bytes 788ms
         ✓ should upload in parts for input type string 1300ms
         ✓ should upload in parts for input type Readable 806ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: CRC32C (4) 4911ms
         ✓ should upload in parts for input type bytes 1127ms
         ✓ should upload in parts for input type string 1647ms
         ✓ should upload in parts for input type Readable 997ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload. 309ms
     ✓ requestChecksumCalculation: WHEN_SUPPORTED (20) 19756ms
       ✓ ChecksumAlgorithm: undefined (4) 3793ms
         ✓ should upload in parts for input type bytes 781ms
         ✓ should upload in parts for input type string 1228ms
         ✓ should upload in parts for input type Readable 763ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: SHA1 (4) 3791ms
         ✓ should upload in parts for input type bytes 748ms
         ✓ should upload in parts for input type string 1240ms
         ✓ should upload in parts for input type Readable 739ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: SHA256 (4) 3765ms
         ✓ should upload in parts for input type bytes 762ms
         ✓ should upload in parts for input type string 1236ms
         ✓ should upload in parts for input type Readable 701ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: CRC32 (4) 3710ms
         ✓ should upload in parts for input type bytes 759ms
         ✓ should upload in parts for input type string 1222ms
         ✓ should upload in parts for input type Readable 690ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload.
       ✓ ChecksumAlgorithm: CRC32C (4) 4697ms
         ✓ should upload in parts for input type bytes 1064ms
         ✓ should upload in parts for input type string 1609ms
         ✓ should upload in parts for input type Readable 906ms
         ✓ should call AbortMultipartUpload if unable to complete a multipart upload. 340ms

 Test Files  1 passed (1)
      Tests  60 passed (60)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title fix(lib-storage): set default ChecksumAlgorithm when calling CreateMPU fix(lib-storage): set ChecksumAlgorithm when calling CreateMPU Jan 15, 2025
@trivikr trivikr marked this pull request as ready for review January 15, 2025 08:08
@trivikr trivikr requested a review from a team as a code owner January 15, 2025 08:08
@trivikr trivikr merged commit 98ab455 into aws:main Jan 15, 2025
4 checks passed
@trivikr trivikr deleted the default-checksum-lib-storage branch January 15, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants