Build script handling of OPT_LEVEL='s' #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
- Coverage 95.80% 92.87% -2.93%
==========================================
Files 61 70 +9
Lines 8143 9517 +1374
Branches 0 9517 +9517
==========================================
+ Hits 7801 8839 +1038
- Misses 342 412 +70
- Partials 0 266 +266 ☔ View full report in Codecov by Sentry. |
|
can anyone review this PR? |
skmcgrail
approved these changes
Feb 17, 2025
WillChilds-Klein
approved these changes
Feb 18, 2025
|
Awesome. thanks @justsmth and @shenjackyuanjie @skmcgrail @WillChilds-Klein !! is there a release that is expected to go out soon? |
We're working on the release now. I'm hopeful the release will be today. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #691
Description of changes:
Improve handling of size-optimized builds, specifically, opt-levels "s" and "z".
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.