Building for Windows (x86_64-pc-windows-msvc) with opt-level="s" causes link errors

[elad-solomon]

Problem:

I am building a rust application that utilizes aws-lc-rs and tonic in Windows.
My application is set to compile with static crt.

I tried to optimize the binary size by changing opt-size to "s", but received this link error:

I was able to reproduce it by building aws-lc-rs with opt-level="s" and env RUSTFLAGS="-C target-feature=+crt-static".

Relevant details

AWS-LC for Rust versions or commit: current master (5af71cc)

I suspect the root cause relies in this logic that chooses the build type based on the opt-level. In MSVC, this directly affects the chosen C runtime, which probably causes the link error above.

[elad-solomon]

Opened a PR that fixes this issue: #692

[justsmth]

Hello! We just released aws-lc-rs v1.12.3 which addresses the problem reported here. This issue will now be resolved. If you continue to experience problems after upgrading, feel free to reopen this issue or create a new one.

Thanks for the report and for helping us improve our library!

[elad-solomon]

Awesome, great news!!
Thanks for the rather quick response on this @justsmth , loving the activeness here in this project.

I think there might be a regression in the arm64 in this release (probably due to other commits unrelated to this issue), check out the issue I created today - #703

nevermind, false positive on my end