Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set chapter-title or section-title attribute in running content to value of toc-title attribute on toc pages #1338

Closed
mojavelinux opened this issue Oct 20, 2019 · 4 comments
Closed

Set chapter-title or section-title attribute in running content to value of toc-title attribute on toc pages #1338

mojavelinux opened this issue Oct 20, 2019 · 4 comments
Assignees
@mojavelinux
Labels
enhancement
Milestone
1.5.0.beta.7

Comments

@mojavelinux
Copy link
Member

mojavelinux commented Oct 20, 2019 •
edited
Loading

When the toc is placed further down in the document using the toc macro, the implicit chapter-title attribute in the running content should be set to value of the toc-title attribute on the toc page. Currently, the chapter-title remains the value of the enclosing chapter. This only applies when the doctype is book.
@mojavelinux mojavelinux added this to the v1.5.0 milestone Oct 20, 2019
@mojavelinux mojavelinux self-assigned this Oct 20, 2019
@mojavelinux
Copy link
Member Author

Or should it be blank, like it is when the toc is in the default location?

@mojavelinux mojavelinux changed the title Implicit chapter-title attribute in running content should match toctitle on toc page when toc placement is macro Implicit chapter-title attribute in running content should match toc-title on toc page when toc placement is macro Oct 20, 2019
@mojavelinux
Copy link
Member Author

It should be the other way around. The value should be set to toc-title, and it should also be set to toc-title when the toc is in the default location.

@mojavelinux
Copy link
Member Author

This uncovered a problem with how titles in the running content are computed. See #1340.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 22, 2019
@mojavelinux
resolves asciidoctor#1338 set chapter-title or section-title attribut…
a87b7af 
…es to value of toc-title attribute on toc pages
@mojavelinux mojavelinux changed the title Implicit chapter-title attribute in running content should match toc-title on toc page when toc placement is macro Set chapter-title or section-title attribute in running content to value of toc-title attribute on toc pages Oct 22, 2019
@mojavelinux
Copy link
Member Author

The PR sets the section-title on pages that have the toc in an article, but I'm not sure this is right. Perhaps if the page doesn't already have a section title? Let's make that a separate issue.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 24, 2019
@mojavelinux
resolves asciidoctor#1338 set chapter-title or section-title attribut…
b5bd604 
…es to value of toc-title attribute on toc pages
@mojavelinux mojavelinux modified the milestones: v1.5.0, 1.5.0.beta.7 Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
enhancement
Projects
None yet
Milestone
1.5.0.beta.7
Development

No branches or pull requests
1 participant
@mojavelinux