Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running content chapter-title attribute on preface pages should match value of preface-title attribute #1340

Closed
mojavelinux opened this issue Oct 21, 2019 · 1 comment
Closed

Running content chapter-title attribute on preface pages should match value of preface-title attribute #1340

mojavelinux opened this issue Oct 21, 2019 · 1 comment
Assignees
@mojavelinux
Labels
bug
Milestone
1.5.0.beta.7

Comments

@mojavelinux
Copy link
Member

The implicit chapter-title attribute in the running content on preface pages should match value of preface-title attribute. Currently, the value on the first page of the preface is the doctitle.
@mojavelinux mojavelinux added this to the v1.5.0 milestone Oct 21, 2019
@mojavelinux mojavelinux self-assigned this Oct 21, 2019
@mojavelinux
Copy link
Member Author

This turns out to be a rather deep bug that is only manifesting itself in this way. The lookup table for the chapter title is being constructed based on the physical page number, but consulted using the virtual page number. This needs to be cleaned up.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 21, 2019
@mojavelinux
resolves asciidoctor#1340 fix value of implicit chapter-title attribu…
d7581c2 
…te on preface pages
@mojavelinux mojavelinux mentioned this issue Oct 21, 2019
Closed
@mojavelinux mojavelinux modified the milestones: v1.5.0, 1.5.0.beta.7 Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
bug
Projects
None yet
Milestone
1.5.0.beta.7
Development

No branches or pull requests
1 participant
@mojavelinux