Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.9.x] License updates per feedback #20428

Merged
merged 5 commits into from
Jul 9, 2021

Conversation

josephevans
Copy link
Contributor

Remove the Apache license header from files already licensed under Caffe license.

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, windows-gpu, centos-cpu, unix-cpu, edge, windows-cpu, website, clang, unix-gpu, sanity, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jul 9, 2021
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we need to cut another RC to include this pr?

@josephevans josephevans requested a review from szha as a code owner July 9, 2021 00:25
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jul 9, 2021
@samskalicky
Copy link
Contributor

LGTM! Do we need to cut another RC to include this pr?

Yes, this will need to be part of rc6

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jul 9, 2021
@josephevans josephevans requested a review from aaronmarkham as a code owner July 9, 2021 17:53
@josephevans josephevans requested a review from marcoabreu as a code owner July 9, 2021 17:53
…cipy 1.7.0 and rand generator test failures.
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jul 9, 2021
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mseth10 mseth10 merged commit 20c4717 into apache:v1.9.x Jul 9, 2021
josephevans added a commit to josephevans/mxnet that referenced this pull request Jul 9, 2021
* Remove Apache license header from files already containing Caffe license.

* Update license check whitelist for files under Caffe license.

* Update rat check exclude list with Caffe-licensed files.

* Don't install caffe python dependencies, as it overwrites our fixed versions.

* Restrict scipy version in test requirements.txt to avoid issue with scipy 1.7.0 and rand generator test failures.
mseth10 pushed a commit that referenced this pull request Jul 12, 2021
* [v1.9.x] License updates per feedback (#20428)

* Remove Apache license header from files already containing Caffe license.

* Update license check whitelist for files under Caffe license.

* Update rat check exclude list with Caffe-licensed files.

* Don't install caffe python dependencies, as it overwrites our fixed versions.

* Restrict scipy version in test requirements.txt to avoid issue with scipy 1.7.0 and rand generator test failures.

* Revert "[v1.x] Skip windows failing tests (#20395)"

This reverts commit 02f4942.

* Update scipy in python requirements for linux docker containers.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants