-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.9.x] License updates per feedback #20428
Conversation
Hey @josephevans , Thanks for submitting the PR
CI supported jobs: [centos-gpu, windows-gpu, centos-cpu, unix-cpu, edge, windows-cpu, website, clang, unix-gpu, sanity, miscellaneous] Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do we need to cut another RC to include this pr?
Yes, this will need to be part of rc6 |
…cipy 1.7.0 and rand generator test failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* Remove Apache license header from files already containing Caffe license. * Update license check whitelist for files under Caffe license. * Update rat check exclude list with Caffe-licensed files. * Don't install caffe python dependencies, as it overwrites our fixed versions. * Restrict scipy version in test requirements.txt to avoid issue with scipy 1.7.0 and rand generator test failures.
* [v1.9.x] License updates per feedback (#20428) * Remove Apache license header from files already containing Caffe license. * Update license check whitelist for files under Caffe license. * Update rat check exclude list with Caffe-licensed files. * Don't install caffe python dependencies, as it overwrites our fixed versions. * Restrict scipy version in test requirements.txt to avoid issue with scipy 1.7.0 and rand generator test failures. * Revert "[v1.x] Skip windows failing tests (#20395)" This reverts commit 02f4942. * Update scipy in python requirements for linux docker containers.
Remove the Apache license header from files already licensed under Caffe license.