[MXNET-1291] solve pylint errors in examples with issue no.12205 #13938

cchung100m · 2019-01-20T04:32:49Z

Description

this is the part 3 of the changes to solve pylint errors in examples with issue #12205

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Feature1, tests, (and when applicable, API doc)
Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

example/bayesian-methods/bdk_demo.py

example/caffe/caffe_net.py

example/caffe/train_model.py

example/cnn_text_classification/data_helpers.py

example/ctc/multiproc_data.py

example/gluon/dc_gan/dcgan.py

example/gluon/lstm_crf/lstm_crf.py

ChaiBapchya

Branch has a merge conflict. Please resolve. Thanks a lot for this really big contribution! Great work!

cchung100m · 2019-01-21T08:31:49Z

@ChaiBapchya ,
I solve the conflict of bdk_demo.py and re-trigger the CI. thank you for the suggestions. :)

marcoabreu · 2019-01-23T00:23:48Z

Thanks a lot for your contribution. Could you find out why our sanity check did not catch this? Also, it seems like you are deleting a bunch of files

cchung100m · 2019-01-23T01:02:37Z

Hi @marcoabreu

Sorry, I don’t know what you want to tell me. Can you elaborate on that?

Many thanks,

example/autoencoder/model.py

example/autoencoder/solver.py

example/bayesian-methods/algos.py

sandeep-krishnamurthy · 2019-01-25T18:47:55Z

example/gluon/audio/urban_sounds/README.md

@@ -1,100 +0,0 @@
-# Urban Sounds Classification in MXNet Gluon


Why is this removed?

Sorry, I don't know anything about this file, I just accept this change which made by communities before committing my branch.

sandeep-krishnamurthy · 2019-01-25T18:49:21Z

@cchung100m - Thank you for your contributions and solving pylint issues in examples. I have left few comments.
How are we testing that examples are not broken after this change? @marcoabreu

marcoabreu · 2019-01-26T05:04:36Z

We don't test examples in CI :(

marcoabreu

Please update out pylint pipeline to ensure all these points are caught in future

vandanavk · 2019-02-05T23:46:22Z

@cchung100m are the files in example/autoencoder being deleted?

@marcoabreu we might have to wait for the fixes to all the lint errors (in examples folder) to be merged, before we enable the check in CI

ankkhedia · 2019-02-14T23:43:03Z

@cchung100m Could you please look into the comments above?

cchung100m · 2019-02-18T00:53:08Z

@vandanavk
Sorry for the late reply.
Yes, the files in example/autoencoder being deleted.

@ankkhedia
Thanks for the reminder.

I will solve the conflict files and rebase this branch ASAP.

vandanavk

LGTM

vandanavk · 2019-03-04T22:00:09Z

@marcoabreu @ChaiBapchya @sandeep-krishnamurthy is this PR good to go?

cchung100m · 2019-03-07T14:16:18Z

I will re-check the conflicting files ASAP.

Unify the style of comments

Correct the misuse of tenses from preprocessed to preprocesses

1. Add reference of the paper in comment. 2. Change the comments from "Run training to CapsNet" to "Perform CapsNet training"

Remove a redundant noun 'dataset'

Align the style of comment from single-line comment to multi-line comment

Correct the misdescription comment of LogSoftmax class from 'softmax loss function' to 'logarithm of softmax'

Remove the '#' symbol in the header comment

update out pylint pipeline to ensure all these points are caught

cchung100m · 2019-03-14T07:47:54Z

Hi @szha @marcoabreu @ChaiBapchya @sandeep-krishnamurthy

I complete the rebase and re-test on this branch, I will appreciate if you can help to review/merge, again, thanks :)

…che#13938) * Unify the style of comments Unify the style of comments * Unify the style of comments Unify the style of comments * Correct the misuse of tenses Correct the misuse of tenses from preprocessed to preprocesses * Enhance the comment for better description 1. Add reference of the paper in comment. 2. Change the comments from "Run training to CapsNet" to "Perform CapsNet training" * Remove a redundant noun Remove a redundant noun 'dataset' * Unify the style of comments Align the style of comment from single-line comment to multi-line comment * Correct the misdescription of LogSoftmax class Correct the misdescription comment of LogSoftmax class from 'softmax loss function' to 'logarithm of softmax' * Remove the '#' symbol in the header comment Remove the '#' symbol in the header comment * update the result of pylint pipeline update out pylint pipeline to ensure all these points are caught * retrigger the CI

) * Unify the style of comments Unify the style of comments * Unify the style of comments Unify the style of comments * Correct the misuse of tenses Correct the misuse of tenses from preprocessed to preprocesses * Enhance the comment for better description 1. Add reference of the paper in comment. 2. Change the comments from "Run training to CapsNet" to "Perform CapsNet training" * Remove a redundant noun Remove a redundant noun 'dataset' * Unify the style of comments Align the style of comment from single-line comment to multi-line comment * Correct the misdescription of LogSoftmax class Correct the misdescription comment of LogSoftmax class from 'softmax loss function' to 'logarithm of softmax' * Remove the '#' symbol in the header comment Remove the '#' symbol in the header comment * update the result of pylint pipeline update out pylint pipeline to ensure all these points are caught * retrigger the CI

…che#13938) * Unify the style of comments Unify the style of comments * Unify the style of comments Unify the style of comments * Correct the misuse of tenses Correct the misuse of tenses from preprocessed to preprocesses * Enhance the comment for better description 1. Add reference of the paper in comment. 2. Change the comments from "Run training to CapsNet" to "Perform CapsNet training" * Remove a redundant noun Remove a redundant noun 'dataset' * Unify the style of comments Align the style of comment from single-line comment to multi-line comment * Correct the misdescription of LogSoftmax class Correct the misdescription comment of LogSoftmax class from 'softmax loss function' to 'logarithm of softmax' * Remove the '#' symbol in the header comment Remove the '#' symbol in the header comment * update the result of pylint pipeline update out pylint pipeline to ensure all these points are caught * retrigger the CI

cchung100m requested a review from szha as a code owner January 20, 2019 04:32

ChaiBapchya reviewed Jan 20, 2019

View reviewed changes

ChaiBapchya suggested changes Jan 20, 2019

View reviewed changes

sandeep-krishnamurthy reviewed Jan 25, 2019

View reviewed changes

sandeep-krishnamurthy added Python CI pr-awaiting-review PR is waiting for code review labels Jan 25, 2019

marcoabreu suggested changes Jan 26, 2019

View reviewed changes

cchung100m force-pushed the issue12205_4 branch from d0bf224 to 61a70dc Compare February 18, 2019 11:46

vandanavk approved these changes Feb 27, 2019

View reviewed changes

cchung100m added 8 commits March 12, 2019 20:49

Unify the style of comments

ac8d43a

Unify the style of comments

Unify the style of comments

c7b4023

Unify the style of comments

Correct the misuse of tenses

62f33d0

Correct the misuse of tenses from preprocessed to preprocesses

Enhance the comment for better description

1a32d6f

1. Add reference of the paper in comment. 2. Change the comments from "Run training to CapsNet" to "Perform CapsNet training"

Remove a redundant noun

4bed591

Remove a redundant noun 'dataset'

Unify the style of comments

174a9e7

Align the style of comment from single-line comment to multi-line comment

Correct the misdescription of LogSoftmax class

4a02a72

Correct the misdescription comment of LogSoftmax class from 'softmax loss function' to 'logarithm of softmax'

Remove the '#' symbol in the header comment

ce04d77

Remove the '#' symbol in the header comment

cchung100m force-pushed the issue12205_4 branch from a3bcf9f to ce04d77 Compare March 12, 2019 12:54

update the result of pylint pipeline

c967642

update out pylint pipeline to ensure all these points are caught

retrigger the CI

66bd55c

marcoabreu merged commit 9fd3153 into apache:master Mar 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13938

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13938

cchung100m commented Jan 20, 2019 •

edited

Loading

ChaiBapchya left a comment

cchung100m commented Jan 21, 2019

marcoabreu commented Jan 23, 2019

cchung100m commented Jan 23, 2019

sandeep-krishnamurthy Jan 25, 2019

cchung100m Jan 26, 2019

sandeep-krishnamurthy commented Jan 25, 2019

marcoabreu commented Jan 26, 2019

marcoabreu left a comment

vandanavk commented Feb 5, 2019

ankkhedia commented Feb 14, 2019

cchung100m commented Feb 18, 2019

vandanavk left a comment

vandanavk commented Mar 4, 2019

cchung100m commented Mar 7, 2019

cchung100m commented Mar 14, 2019

		@@ -1,100 +0,0 @@
		# Urban Sounds Classification in MXNet Gluon

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13938

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13938

Conversation

cchung100m commented Jan 20, 2019 • edited Loading

Description

Checklist

Essentials

Changes

Comments

ChaiBapchya left a comment

Choose a reason for hiding this comment

cchung100m commented Jan 21, 2019

marcoabreu commented Jan 23, 2019

cchung100m commented Jan 23, 2019

sandeep-krishnamurthy Jan 25, 2019

Choose a reason for hiding this comment

cchung100m Jan 26, 2019

Choose a reason for hiding this comment

sandeep-krishnamurthy commented Jan 25, 2019

marcoabreu commented Jan 26, 2019

marcoabreu left a comment

Choose a reason for hiding this comment

vandanavk commented Feb 5, 2019

ankkhedia commented Feb 14, 2019

cchung100m commented Feb 18, 2019

vandanavk left a comment

Choose a reason for hiding this comment

vandanavk commented Mar 4, 2019

cchung100m commented Mar 7, 2019

cchung100m commented Mar 14, 2019

cchung100m commented Jan 20, 2019 •

edited

Loading