-
Notifications
You must be signed in to change notification settings - Fork 272
fix(plugin-chart-echarts): fix tick labels and tooltip #1447
fix(plugin-chart-echarts): fix tick labels and tooltip #1447
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/2d1W5aV4E93vwe1u7yTJQJuahH2v |
f29a272
to
d7575a3
Compare
plugins/plugin-chart-echarts/src/MixedTimeseries/EchartsMixedTimeseries.tsx
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1447 +/- ##
==========================================
- Coverage 30.43% 30.43% -0.01%
==========================================
Files 497 497
Lines 10012 10013 +1
Branches 1691 1692 +1
==========================================
Hits 3047 3047
- Misses 6719 6720 +1
Partials 246 246
Continue to review full report at Codecov.
|
Thanks for the improvement! LGTM and just left a comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🐛 Bug Fix
Fixes multiple issues on the Mixed Timeseries chart:
0NaN
when rich tooltip is disabled and the value is a decimal.AFTER
Tooltip correctly shows the x-axis value when the y-value is a decimal:
The erroneous min and max x-axis values are removed, and hovering on a bar underneath a line works as intended:
https://user-images.githubusercontent.com/33317356/139655494-8ab0257a-2ece-4821-a41e-727437cd8490.mp4
BEFORE
Tooltip shows
0NaN
when the metric value is a decimal value:The x-axis shows incorrect min and max values, and hovering on a bar underneath a line doesn't display the bar value correctly:
https://user-images.githubusercontent.com/33317356/139655424-20628415-b6a2-46a7-81e7-fb310e894e19.mp4